linux-kernel - Re: watchdog: pcwd driver updates (was: No subject)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0ce066a-fa24-1e56-ade9-22d7cde18c14@suse.com>
Date:   Thu, 27 Apr 2023 16:19:49 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Oliver Neukum <oneukum@...e.com>, wim@...ux-watchdog.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: watchdog: pcwd driver updates (was: No subject)



On 27.04.23 16:12, Guenter Roeck wrote:
> Oliver,
> 
> On 4/27/23 06:33, Oliver Neukum wrote:
>> This fixes some long standing deficiencies in error handling,
>> several race conditions and disconnect handling.
>> Finally a cleanup as we now can get the device easily
>> from the interface.
>>
> 
> This series is a no-go. If you want to improve the driver, please
> convert it to use the watchdog subsystem API.
> 
> Please note that the subject of your patches should start with
> "watchdog: pcwd:"

Hi,

this would be problematic, because I do not have the hardware
and given its age I won't. I certainly will break the driver
if I do this extensive a change without testing it.

However, as is the driver has obvious issues, which I can fix.
We can either do the sensible fixes or let it quietly rot.

	Regards
		Oliver