linux-kernel - Re: [PATCH v8 2/2] leds: lp55xx: configure internal charge pump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230427152153.GY50521@google.com>
Date:   Thu, 27 Apr 2023 16:21:53 +0100
From:   Lee Jones <lee@...nel.org>
To:     Maarten Zanders <maarten.zanders@...d.be>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/2] leds: lp55xx: configure internal charge pump

On Fri, 21 Apr 2023, Maarten Zanders wrote:

> The LP55xx range of devices have an internal charge pump which
> can (automatically) increase the output voltage towards the
> LED's, boosting the output voltage to 4.5V.
> 
> Implement this option from the devicetree. When the setting
> is not present it will operate in automatic mode as before.
> 
> Tested on LP55231. Datasheet analysis shows that LP5521, LP5523
> and LP8501 are identical in topology and are modified in the
> same way.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders@...d.be>
> ---
> 
> Notes:
>     v1: implement as bool to disable charge pump
>     v2: rewrite to use string configuration, supporting all modes
>     v3: simplification by replacing string from DTS by constant
>     v4: added notes
>     v5: property type to u32
>     v6: cleanup parsing of DT paramter
>     v7: formatting
> 
>  drivers/leds/leds-lp5521.c                | 11 +++++------
>  drivers/leds/leds-lp5523.c                | 14 +++++++++-----
>  drivers/leds/leds-lp55xx-common.c         |  9 +++++++++
>  drivers/leds/leds-lp8501.c                |  8 +++++---
>  include/linux/platform_data/leds-lp55xx.h |  3 +++
>  5 files changed, 31 insertions(+), 14 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]