[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAF8JNh+ps2F=vCr6GwpB7NAj8-graAw1-oCV2DonJWw8YA8p9g@mail.gmail.com>
Date: Thu, 27 Apr 2023 10:56:40 -0700
From: Ping Cheng <pinglinux@...il.com>
To: Denis Arefev <arefev@...mel.ru>
Cc: Ping Cheng <ping.cheng@...om.com>,
Jason Gerecke <jason.gerecke@...om.com>,
Jiri Kosina <jikos@...nel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org, trufanov@...mel.ru, vfh@...mel.ru
Subject: Re: [PATCH] HID: wacom: Added error check
On Thu, Apr 27, 2023 at 5:07 AM Denis Arefev <arefev@...mel.ru> wrote:
>
> Added a variable check and
> transition in case of an error
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <arefev@...mel.ru>
Thank you Denis for working on the patch! The patch LGTM.
Reviewed-by: Ping Cheng <ping.cheng@...om.com>
Cheers,
Ping
> ---
> drivers/hid/wacom_sys.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index fb538a6c4add..aff4a21a46b6 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -2417,8 +2417,13 @@ static int wacom_parse_and_register(struct wacom *wacom, bool wireless)
> goto fail_quirks;
> }
>
> - if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR)
> + if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR) {
> error = hid_hw_open(hdev);
> + if (error) {
> + hid_err(hdev, "hw open failed\n");
> + goto fail_quirks;
> + }
> + }
>
> wacom_set_shared_values(wacom_wac);
> devres_close_group(&hdev->dev, wacom);
> --
> 2.25.1
>
Powered by blists - more mailing lists