linux-kernel - Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1fd47550-ba39-9755-e0ce-8c377cecb2c4@kernel.org>
Date:   Thu, 27 Apr 2023 13:58:47 -0500
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Richard Gong <richard.gong@...el.com>
Cc:     Alan Tull <atull@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in
 probe



On 4/19/23 09:27, Dan Carpenter wrote:
> The svc_create_memory_pool() function returns error pointers.  It never
> returns NULL.  Fix the check.
> 
> Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/firmware/stratix10-svc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index bde1f543f529..80f4e2d14e04 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -1133,8 +1133,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev)
>   		return ret;
>   
>   	genpool = svc_create_memory_pool(pdev, sh_memory);
> -	if (!genpool)
> -		return -ENOMEM;
> +	if (IS_ERR(genpool))
> +		return PTR_ERR(genpool);
>   
>   	/* allocate service controller and supporting channel */
>   	controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);

Acked-by: Dinh Nguyen <dinguyen@...nel.org>