linux-kernel - Re: [STYLE v1 1/3] cxl/mbox: remove redundant debug msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <644ac773f2929_182a92942f@iweiny-mobl.notmuch>
Date:   Thu, 27 Apr 2023 12:05:24 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Raghu H <raghuhack78@...il.com>, <linux-cxl@...r.kernel.org>,
        "Alison Schofield" <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [STYLE v1 1/3] cxl/mbox: remove redundant debug msg

Raghu H wrote:
> A return of errno should be good enough if the memory allocation fails,
> the debug message here is redundatant as per the coding style, removing it.
> 
> Signed-off-by: Raghu H <raghuhack78@...il.com>

I'm not seeing a lot of value in this error message either.  There are
plenty of other places probe can fail without any errors at all.

I guess:

Reviewed-by: Ira Weiny <ira.weiny@...el.com>