linux-kernel - Re: [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2023 12:06:27 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Raghu H <raghuhack78@...il.com>, <linux-cxl@...r.kernel.org>,
        "Alison Schofield" <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors

Raghu H wrote:
> Styling errors due to linux of unwanted spaces in the definition,
> modified the definition to use tab to fix the styling issue.
> 
> Signed-off-by: Raghu H <raghuhack78@...il.com>

NAK

This is unnecessary churn.  The formatting of the file is fine and very
readable.

Ira

> ---
>  drivers/cxl/core/port.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 8ee6b6e2e2a4..7c3aaed180ca 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -95,15 +95,15 @@ static ssize_t size_show(struct device *dev, struct device_attribute *attr,
>  }
>  static DEVICE_ATTR_RO(size);
>  
> -#define CXL_DECODER_FLAG_ATTR(name, flag)                            \
> -static ssize_t name##_show(struct device *dev,                       \
> -			   struct device_attribute *attr, char *buf) \
> -{                                                                    \
> -	struct cxl_decoder *cxld = to_cxl_decoder(dev);              \
> -                                                                     \
> -	return sysfs_emit(buf, "%s\n",                               \
> -			  (cxld->flags & (flag)) ? "1" : "0");       \
> -}                                                                    \
> +#define CXL_DECODER_FLAG_ATTR(name, flag)				\
> +static ssize_t name##_show(struct device *dev,				\
> +			   struct device_attribute *attr, char *buf)	\
> +{									\
> +	struct cxl_decoder *cxld = to_cxl_decoder(dev);			\
> +									\
> +	return sysfs_emit(buf, "%s\n",					\
> +			  (cxld->flags & (flag)) ? "1" : "0");		\
> +}									\
>  static DEVICE_ATTR_RO(name)
>  
>  CXL_DECODER_FLAG_ATTR(cap_pmem, CXL_DECODER_F_PMEM);
> -- 
> 2.39.2
>