linux-kernel - Re: [PATCH bpf-next] selftests/bpf: Update the aarch64 tests deny list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60a7370b-9e6a-cba3-4d63-76d47a780982@iogearbox.net>
Date:   Thu, 27 Apr 2023 22:10:50 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>,
        Florent Revest <revest@...omium.org>
Cc:     bpf@...r.kernel.org, linux-kernel@...r.kernel.org, ast@...nel.org,
        andrii@...nel.org, kpsingh@...nel.org, mykolal@...com,
        martin.lau@...ux.dev, song@...nel.org, xukuohai@...weicloud.com,
        mark.rutland@....com
Subject: Re: [PATCH bpf-next] selftests/bpf: Update the aarch64 tests deny
 list

On 4/27/23 8:56 PM, Stanislav Fomichev wrote:
> On 04/27, Florent Revest wrote:
>> On Thu, Apr 27, 2023 at 4:32 PM Florent Revest <revest@...omium.org> wrote:
>>>
>>> This patch updates the list of BPF selftests which are known to fail so
>>> the BPF CI can validate the tests which pass now.
>>
>> Note: I tested this denylist a few months back by sending a manual PR
>> to https://github.com/kernel-patches/bpf.
>> At the time, it worked
>> https://github.com/kernel-patches/bpf/actions/runs/4106542133/jobs/7085514761
>> (even though there seemed to be a known flake in the gcc variant but
>> unrelated to the new arch support)
>>
>> Every time I wanted to have the CI run on my PRs, I had to annoy Manu
>> by email (I wouldn't have the rights to trigger the CI by myself
>> otherwise). So I haven't tested this *actual* patch rebased on the
>> current CI before sending it to the list. (e.g. the
>> module_fentry_shadow test has been added since then and I just assumed
>> it would pass in CI like the rest)
>>
>> My understanding is that this patch should soon be picked up by the
>> testing bot and we can use that CI run to check that everything works
>> as intended. Let's wait for a CI green light before merging this! :)
>> If there are errors I'll send a v2
> 
> Looks green now:
> 
> Acked-by: Stanislav Fomichev <sdf@...gle.com>
> 
> https://github.com/kernel-patches/bpf/actions/runs/4822595792/jobs/8590732278

That's awesome to see ... big batch of tests which this unlocks!