linux-kernel - Re: [PATCH] imx8mn-var-som: dts: fix PHY detection bug by adding deassert delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76302757-5359-5e70-02e2-daf0923843cb@pengutronix.de>
Date:   Thu, 27 Apr 2023 22:16:45 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Hugo Villeneuve <hugo@...ovil.com>,
        Fabio Estevam <festevam@...il.com>
Cc:     devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] imx8mn-var-som: dts: fix PHY detection bug by adding
 deassert delay

On 27.04.23 22:12, Hugo Villeneuve wrote:
> On Thu, 27 Apr 2023 17:07:59 -0300
> Fabio Estevam <festevam@...il.com> wrote:
> 
>> On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <hugo@...ovil.com> wrote:
>>
>>> Hi Fabio,
>>> it uses a ADIN1300 PHY.
>>>
>>> The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
>>
>> Please add this information to the commit log and please add a Fixes: tag.
> 
> Good idea, will do.

Please also add the PHY name into the DT, e.g.:

  ethphy: ethernet-phy@4 { /* ADIN1300 */

I find this very useful when bringing up a new board and looking
for similar DTs.

Thanks,
Ahmad

> 
> Hugo.
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |