linux-kernel - Re: [RFC PATCH v2 3/3] resource, crash: Make kexec_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2023 13:41:19 -0700
From:   Jane Chu <jane.chu@...cle.com>
To:     Li Zhijian <lizhijian@...itsu.com>, x86@...nel.org,
        nvdimm@...ts.linux.dev, kexec@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, y-goto@...itsu.com,
        yangx.jy@...itsu.com, ruansy.fnst@...itsu.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Takashi Iwai <tiwai@...e.de>, Baoquan He <bhe@...hat.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Sean Christopherson <seanjc@...gle.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Ira Weiny <ira.weiny@...el.com>,
        Raul E Rangel <rrangel@...omium.org>,
        Colin Foster <colin.foster@...advantage.com>,
        Vishal Verma <vishal.l.verma@...el.com>
Subject: Re: [RFC PATCH v2 3/3] resource, crash: Make kexec_file_load support
 pmem

> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index cdd92ab43cda..dc9d03083565 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -178,6 +178,7 @@ static struct crash_mem *fill_up_crash_elf_data(void)
>   	if (!nr_ranges)
>   		return NULL;
>   
> +	walk_pmem_res(0, -1, &nr_ranges, get_nr_ram_ranges_callback);

So this will overwrite 'nr_ranges' produced by the previous 
walk_system_ram_res() call, sure it's correct?

Regards,
-jane