Message-ID: <CH3PR12MB83085CE44374A0A37E860B66E86B9@CH3PR12MB8308.namprd12.prod.outlook.com>
Date:   Fri, 28 Apr 2023 10:53:11 +0000
From:   "Gupta, Nipun" <Nipun.Gupta@....com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "song.bao.hua@...ilicon.com" <song.bao.hua@...ilicon.com>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "maz@...nel.org" <maz@...nel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "jeffrey.l.hugo@...il.com" <jeffrey.l.hugo@...il.com>,
        "saravanak@...gle.com" <saravanak@...gle.com>,
        "Michael.Srba@...nam.cz" <Michael.Srba@...nam.cz>,
        "mani@...nel.org" <mani@...nel.org>,
        "yishaih@...dia.com" <yishaih@...dia.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "jgg@...dia.com" <jgg@...dia.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "will@...nel.org" <will@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "okaya@...nel.org" <okaya@...nel.org>,
        "Anand, Harpreet" <harpreet.anand@....com>,
        "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Simek, Michal" <michal.simek@....com>,
        "Jansen Van Vuuren, Pieter" <pieter.jansen-van-vuuren@....com>,
        "Cascon, Pablo" <pablo.cascon@....com>,
        "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware
 interaction



> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@...ts.infradead.org> On
> Behalf Of Geert Uytterhoeven
> Sent: Friday, April 28, 2023 1:44 PM
> To: Gupta, Nipun <Nipun.Gupta@....com>
> Cc: robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> gregkh@...uxfoundation.org; rafael@...nel.org; eric.auger@...hat.com;
> alex.williamson@...hat.com; cohuck@...hat.com;
> song.bao.hua@...ilicon.com; mchehab+huawei@...nel.org; maz@...nel.org;
> f.fainelli@...il.com; jeffrey.l.hugo@...il.com; saravanak@...gle.com;
> Michael.Srba@...nam.cz; mani@...nel.org; yishaih@...dia.com;
> jgg@...pe.ca; jgg@...dia.com; robin.murphy@....com; will@...nel.org;
> joro@...tes.org; masahiroy@...nel.org; ndesaulniers@...gle.com;
> rdunlap@...radead.org; baolu.lu@...ux.intel.com; linux-arm-
> kernel@...ts.infradead.org; linux-kbuild@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; okaya@...nel.org;
> Anand, Harpreet <harpreet.anand@....com>; Agarwal, Nikhil
> <nikhil.agarwal@....com>; Simek, Michal <michal.simek@....com>; Jansen
> Van Vuuren, Pieter <pieter.jansen-van-vuuren@....com>; Cascon, Pablo
> <pablo.cascon@....com>; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware
> interaction
> 
> 
> Hi Nipun,
> 
> On Mon, Mar 13, 2023 at 2:28 PM Nipun Gupta <nipun.gupta@....com>
> wrote:
> > The MCDI (Management CPU Driver Interface) is used as a
> > protocol to communicate with the RPU firmware. It has
> > pre-defined set of messages for different message exchanges
> > between APU and RPU.
> >
> > Signed-off-by: Puneet Gupta <puneet.gupta@....com>
> > Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> > Signed-off-by: Tarak Reddy <tarak.reddy@....com>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@....com>
> 
> Thanks for your patch, which is now commit eb96b740192b2a09 ("cdx:
> add MCDI protocol interface for firmware interaction") upstream.
> 
> > --- /dev/null
> > +++ b/drivers/cdx/controller/Kconfig
> > @@ -0,0 +1,20 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
> > +# CDX controller configuration
> > +#
> > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc.
> > +#
> > +
> > +if CDX_BUS
> > +
> > +config MCDI_LOGGING
> > +       bool "MCDI Logging for the CDX controller"
> > +       depends on CDX_CONTROLLER
> > +       help
> > +         Enable MCDI Logging for
> > +         the CDX Controller for debug
> > +         purpose.
> > +
> > +         If unsure, say N.
> > +
> > +endif
> 
> As there also exist config symbols SFC_MCDI_LOGGING and
> SFC_SIENA_MCDI_LOGGING, perhaps MCDI_LOGGING is too generic, and
> should
> be renamed to CDX_MCDI_LOGGING?

Sure, we will add a patch to rename this.

Thanks,
Nipun

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Powered by blists - more mailing lists