linux-kernel - Re: [PATCH 29/43] rtc: m48t86: add DT support for m48t86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bd4554f1910ba253d7833bae99d7c00b9098eae2.camel@maquefel.me>
Date:   Fri, 28 Apr 2023 17:31:01 +0300
From:   Nikita Shubin <nikita.shubin@...uefel.me>
To:     andy.shevchenko@...il.com
Cc:     Arnd Bergmann <arnd@...nel.org>, Linus Walleij <linusw@...nel.org>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 29/43] rtc: m48t86: add DT support for m48t86

On Wed, 2023-04-26 at 16:36 +0300, andy.shevchenko@...il.com wrote:
> Mon, Apr 24, 2023 at 03:34:45PM +0300, Nikita Shubin kirjoitti:
> > - get regs from device tree
> 
> ...
> 
> > +#include <linux/of.h>
> 
> mod_devicetable.h and drop ugly ifdeffery along with of_match_ptr().
> 
> ...
> 
> > +static const struct of_device_id m48t86_rtc_of_ids[] = {
> > +       { .compatible = "dallas,rtc-m48t86" },
> > +       { /* end of table */ },
> 
> No comma for the terminator entry
> 
> > +};
> 

Thanks you for all your comments and effort!

All will be fixed conforming your comments.