linux-kernel - Re: [PATCH v2 0/3] io_uring: Pass the whole sqe to commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <678232fa-fd02-37b7-3048-a124c4ffdc71@kernel.dk>
Date:   Fri, 28 Apr 2023 11:28:14 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Breno Leitao <leitao@...ian.org>, io-uring@...r.kernel.org,
        linux-nvme@...ts.infradead.org, asml.silence@...il.com
Cc:     leit@...com, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, sagi@...mberg.me, hch@....de,
        kbusch@...nel.org, ming.lei@...hat.com
Subject: Re: [PATCH v2 0/3] io_uring: Pass the whole sqe to commands

On 4/21/23 5:44?AM, Breno Leitao wrote:
> These three patches prepare for the sock support in the io_uring cmd, as
> described in the following RFC:
> 
> 	https://lore.kernel.org/lkml/20230406144330.1932798-1-leitao@debian.org/
> 
> Since the support linked above depends on other refactors, such as the sock
> ioctl() sock refactor[1], I would like to start integrating patches that have
> consensus and can bring value right now.  This will also reduce the patchset
> size later.
> 
> Regarding to these three patches, they are simple changes that turn
> io_uring cmd subsystem more flexible (by passing the whole SQE to the
> command), and cleaning up an unnecessary compile check.
> 
> These patches were tested by creating a file system and mounting an NVME disk
> using ubdsrv/ublkb0.

Looks mostly good to me, do agree with Christoph's comments on the two
patches. Can you spin a v3? Would be annoying to miss 6.4 with this, as
other things will be built on top of it.

-- 
Jens Axboe