linux-kernel - Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add support for ADC nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f553758-c2cc-ce70-47e0-99e08c2d94a1@ti.com>
Date:   Fri, 28 Apr 2023 23:19:51 +0530
From:   "Raghavendra, Vignesh" <vigneshr@...com>
To:     Bhavya Kapoor <b-kapoor@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <robh+dt@...nel.org>,
        <kristo@...nel.org>, <nm@...com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add support for
 ADC nodes



On 4/12/2023 3:39 PM, Bhavya Kapoor wrote:
> J784S4 has two instances of 8 channel ADCs in MCU domain. Add support
> for both ADC nodes.
> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@...com>
> ---
>  .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi     | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> index f04fcb614cbe..cb5ba5e94ec7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> @@ -342,4 +342,44 @@ cpts@...00 {
>  			ti,cpts-periodic-outputs = <2>;
>  		};
>  	};
> +
> +	tscadc0: tscadc@...00000 {
> +		compatible = "ti,am3359-tscadc";
> +		reg = <0x00 0x40200000 0x00 0x1000>;
> +		interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 0 0>;
> +		assigned-clocks = <&k3_clks 0 2>;
> +		assigned-clock-rates = <60000000>;
> +		clock-names = "fck";
> +		dmas = <&main_udmap 0x7400>,
> +				<&main_udmap 0x7401>;

Please fix alignment issue:

		dmas = <&main_udmap 0x7400>,
		       <&main_udmap 0x7401>;

> +		dma-names = "fifo0", "fifo1";
> +		status = "disabled";
> +
> +		adc {
> +				#io-channel-cells = <1>;
> +				compatible = "ti,am3359-adc";

Excessive indentation

> +		};
> +	};
> +
> +	tscadc1: tscadc@...10000 {
> +		compatible = "ti,am3359-tscadc";
> +		reg = <0x00 0x40210000 0x00 0x1000>;
> +		interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 1 0>;
> +		assigned-clocks = <&k3_clks 1 2>;
> +		assigned-clock-rates = <60000000>;
> +		clock-names = "fck";
> +		dmas = <&main_udmap 0x7402>,
> +				<&main_udmap 0x7403>;

ditto

> +		dma-names = "fifo0", "fifo1";
> +		status = "disabled";
> +
> +		adc {
> +				#io-channel-cells = <1>;
> +				compatible = "ti,am3359-adc";

Same here

> +		};
> +	};
>  };