linux-kernel - Re: [PATCH] usb: dwc3: gadget: Fix controller timeout at dwc3_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230428184055.cm3lae6dmmfxgjc6@synopsys.com>
Date:   Fri, 28 Apr 2023 18:40:59 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Roger Quadros <rogerq@...nel.org>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "r-gunasekaran@...com" <r-gunasekaran@...com>,
        "srk@...com" <srk@...com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Fix controller timeout at
 dwc3_gadget_suspend()

On Fri, Apr 28, 2023, Roger Quadros wrote:
> If gadget driver is loaded and we are connected to a USB host,
> all transfers must be stopped before stopping the controller else
> we will not get a clean stop i.e. dwc3_gadget_run_stop() will take
> several seconds to complete and will return -ETIMEDOUT. Fix this.
> 
> No need to stop the controller at dwc3_gadget_suspend() if
> dwc->softconnect is 0 as controller is already stopped.
> 
> Handle error cases properly in dwc3_gadget_suspend().

We also fix the dwc3_gadget_resume() in this change. Either create a
separate change or note it in the $subject and commit message.

> 
> Suggested-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> Signed-off-by: Roger Quadros <rogerq@...nel.org>

Perhaps this needs a fixes tag? (Even though it can't be backported
cleanly without some modifications)

Also, please rebase your change to Greg's usb-next.

Thanks!
Thinh