linux-kernel - Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5be7e9de-a81b-c0c8-2231-06144ff3cdea@gmail.com>
Date:   Fri, 28 Apr 2023 11:51:39 -0700
From:   Doug Berger <opendmb@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, linus.walleij@...aro.org
Cc:     brgl@...ev.pl, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] gpio: brcmstb: Use
 devm_platform_get_and_ioremap_resource()

On 4/27/2023 11:11 PM, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/gpio/gpio-brcmstb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>   	platform_set_drvdata(pdev, priv);
>   	INIT_LIST_HEAD(&priv->bank_list);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	reg_base = devm_ioremap_resource(dev, res);
> +	reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(reg_base))
>   		return PTR_ERR(reg_base);
>   
Acked-by: Doug Berger <opendmb@...il.com>