linux-kernel - Re: [PATCH] Call input_set_timestamp for events injected using uinput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEwkWAtpwdUiqHb1@google.com>
Date:   Fri, 28 Apr 2023 12:54:00 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Siarhei Vishniakou <svv@...gle.com>
Cc:     Biswarup Pal <biswarupp@...gle.com>, kernel-team@...roid.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Call input_set_timestamp for events injected using uinput

On Fri, Apr 28, 2023 at 12:52:43PM -0700, Dmitry Torokhov wrote:
> Hi,
> 
> On Fri, Apr 28, 2023 at 11:38:36AM -0700, Siarhei Vishniakou wrote:
> > Thanks Biswarup!
> 
> Please avoid top posting.
> 
> > 
> > Just to add a bit of context: we were concerned with  breaking the
> > existing uinput usages where the caller might be setting an incorrect
> > value (since previously, that had no effect).
> > So the 10 second guard was added to fall back to the default behaviour
> > for those devices.
> 
> What is the benefit of sending this in uinput? It is not much close
> to the exact time the hardware generated the event than the timestamp
> generated in the input core, so I do not see why it is needed in uinput.

Ah, sorry, my apologies, I mis-parsed the code.

-- 
Dmitry