linux-kernel - Re: (subset) [PATCH v3 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168271198315.17728.9108874132629533053.b4-ty@quicinc.com>
Date:   Fri, 28 Apr 2023 13:00:30 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Marijn Suijten <marijn.suijten@...ainline.org>
CC:     Abhinav Kumar <quic_abhinavk@...cinc.com>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Martin Botka <martin.botka@...ainline.org>,
        "Jami Kettunen" <jami.kettunen@...ainline.org>,
        Jordan Crouse <jordan@...micpenguin.net>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>
Subject: Re: (subset) [PATCH v3 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup


On Wed, 26 Apr 2023 01:11:08 +0200, Marijn Suijten wrote:
> Doing a for loop in every DPU HW block driver init to find a catalog
> entry matching the given ID is rather useless if the init function
> called by RM already has that catalog entry pointer, and uses exactly
> its ID to drive this init and for loop.  Remove all that machinery to
> drop quite some lines of unnecessarily-complicated code, and the
> fallibility that comes with it, by simply giving _init() the catalog
> entry pointers straight away.
> 
> [...]

Applied, thanks!

[1/3] drm/msm/dpu: Assign missing writeback log_mask
      https://gitlab.freedesktop.org/abhinavk/msm/-/commit/a432fc31f03d

Best regards,
-- 
Abhinav Kumar <quic_abhinavk@...cinc.com>