linux-kernel - Re: Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0a986aaf5acf10af3a6a3a0220791d18d18df0e.camel@vmware.com>
Date:   Fri, 28 Apr 2023 03:35:20 +0000
From:   Zack Rusin <zackr@...are.com>
To:     "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        "zhouzongmin@...inos.cn" <zhouzongmin@...inos.cn>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>
CC:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] Input: vmmouse - add macros to enable vmmouse
 relative mode

On Fri, 2023-04-28 at 10:34 +0800, zongmin zhou wrote:
> On Thu, 2023-04-20 at 09:49 +0800, 周宗敏 wrote:
> > > Dear zack:
> > >
> > > As far as I know, I think in the current design for vmmouse device,
> > > the mouse mode can only choose one,can't request both two mode.
> > >
> > > The flowchart for vmmouse device between host and guest roughly as
> > > > follows：
> picture link:
> https://imgs.wiki/imgs/2023/04/28/1898b0428ecb366a.png
>
> > > QEMU VMMouse emulation code defined variables of 's->absolute'
> > > to identify the mouse mode requested by the guest driver.
> > > Based on the value of 's->absolute',qemu will add different >
> > > spice-input VD-Interface,
> > > spice-server will notify client to use the correct mouse mode,
> > > and then spice client will update mouse motion/position based on
> > > the > mouse mode.
> > >
> > > About the VMMOUSE_RELATIVE_PACKET events,I guess that designer may
> > > > want use it
> > > to distinguish relative from absolute of the process events.But >
> > > doesn't mark them as such
> > > on QEMU's vmmouse device code.In fact, the status corresponds to
> > > the > following buttons value on QEMU：
> link:
> https://imgs.wiki/imgs/2023/04/28/2c6a92c33e2537dd.png
> > >
> > > From the screenshot we can know it didn't mark the mouse mode
> > > status > on original design,
> > > only set the actual button state. So I think have to mark it here >
> > > according to the value of 's->absolute'.
> > >
> Dear zack:
>
> I guess the last mail sent to you may has been lost
> as I don't see it in lore.kernel.org.Just resending it.

Do you mean the one I replied to yesterday? My reply to it is here
https://lore.kernel.org/lkml/3a4f27ad2122fe0457dc2a41a3b1b24ac556d26c.camel@vmware.com/
(and surely somewhere in your inbox as well)

z