linux-kernel - Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2023 16:06:50 -0500
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>, herbert@...dor.apana.org.au,
        davem@...emloft.net, fenghua.yu@...el.com, vkoul@...nel.org
Cc:     dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, giovanni.cabiddu@...el.com,
        hdanton@...a.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator
 stats

Hi Randy,

On Fri, 2023-04-28 at 14:00 -0700, Randy Dunlap wrote:
> Hi--
> 
> On 4/28/23 13:55, Tom Zanussi wrote:
> > diff --git a/drivers/crypto/intel/iaa/Kconfig
> > b/drivers/crypto/intel/iaa/Kconfig
> > index fcccb6ff7e29..cffb3a4359fc 100644
> > --- a/drivers/crypto/intel/iaa/Kconfig
> > +++ b/drivers/crypto/intel/iaa/Kconfig
> > @@ -8,3 +8,12 @@ config CRYPTO_DEV_IAA_CRYPTO
> >           decompression with the Intel Analytics Accelerator (IAA)
> >           hardware using the cryptographic API.  If you choose 'M'
> >           here, the module will be called iaa_crypto.
> > +
> > +config CRYPTO_DEV_IAA_CRYPTO_STATS
> > +       bool "Enable Intel(R) IAA Compression Accelerator
> > Statistics"
> > +       depends on CRYPTO_DEV_IAA_CRYPTO
> > +       default n
> > +       help
> > +          Enable statistics for the IAA compression accelerator.
> 
> The line above should use one tab + 2 spaces for indentation
> instead of bunch-of-spaces.

Yep, so much for consistency, will fix.  Thanks for pointing it out.

Tom

> 
> > +         These include per-device and per-workqueue statistics in
> > +         addition to global driver statistics.
> 
> Thanks.