linux-kernel - Re: [PATCH v2] block: Skip destroyed blkg when restart in blkg_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEzC1BAX7e7t8Jaj@linux.bj.intel.com>
Date:   Sat, 29 Apr 2023 15:10:12 +0800
From:   Tao Su <tao1.su@...ux.intel.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        tj@...nel.org, josef@...icpanda.com, yukuai1@...weicloud.com
Subject: Re: [PATCH v2] block: Skip destroyed blkg when restart in
 blkg_destroy_all()

On Fri, Apr 28, 2023 at 11:24:20AM -0600, Jens Axboe wrote:
> 
> On Fri, 28 Apr 2023 12:51:49 +0800, Tao Su wrote:
> > Kernel hang in blkg_destroy_all() when total blkg greater than
> > BLKG_DESTROY_BATCH_SIZE, because of not removing destroyed blkg in
> > blkg_list. So the size of blkg_list is same after destroying a
> > batch of blkg, and the infinite 'restart' occurs.
> > 
> > Since blkg should stay on the queue list until blkg_free_workfn(),
> > skip destroyed blkg when restart a new round, which will solve this
> > kernel hang issue and satisfy the previous will to restart.
> > 
> > [...]
> 
> Applied, thanks!

Axboe, thanks!

Tao

> 
> [1/1] block: Skip destroyed blkg when restart in blkg_destroy_all()
>       commit: 8176080d59e6d4ff9fc97ae534063073b4f7a715
> 
> Best regards,
> -- 
> Jens Axboe
> 
> 
>