[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <712cd0a7-fdb9-059a-90b7-5c3b6a08fd5b@gmail.com>
Date: Sat, 29 Apr 2023 17:55:40 +0200
From: Artur Weber <aweber.kernel@...il.com>
To: Henrik Grimler <henrik@...mler.se>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Rob Herring <robh+dt@...nel.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Tomasz Figa <tomasz.figa@...il.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Olof Johansson <olof@...om.net>, soc@...nel.org,
Russell King <linux@...linux.org.uk>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Kukjin Kim <kgene@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
linux-pm@...r.kernel.org, linux-media@...r.kernel.org,
linux-phy@...ts.infradead.org,
~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 03/12] ARM: exynos: Re-introduce Exynos4212 support
On 19/04/2023 22:24, Henrik Grimler wrote:
>> /*
>> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>> + * But, Exynos4212 has only one secondary CPU so second parameter
>> + * isn't used for informing secure firmware about CPU id.
>> */
>> + if (soc_is_exynos4212())
>> + cpu = 0;
>
> Is it necessary to set cpu = 0? Are there any obvious issues without
> it (like second cpu not being brought up)?
Just tested this; looks like it's required here, without it the second
core fails to start up:
[ 0.064277] smp: Bringing up secondary CPUs ...
[ 1.067163] CPU1: failed to boot: -110
[ 1.069683] smp: Brought up 1 node, 1 CPU
[ 1.072470] SMP: Total of 1 processors activated (48.00 BogoMIPS).
SBOOT on my tablet claims the version is T310XXSBQB2, so it should match
with the one you checked.
Best regards
Artur Weber
Powered by blists - more mailing lists