linux-kernel - Re: [PATCH 08/19] riscv: Add explicit include for cpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-3fdcd7ba-9d00-4521-a55f-367cf53f5f12@palmer-ri-x1c9a>
Date:   Sat, 29 Apr 2023 11:24:49 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     robh@...nel.org
CC:     davem@...emloft.net, robh+dt@...nel.org, frowand.list@...il.com,
        linux@...linux.org.uk, wens@...e.org, jernej.skrabec@...il.com,
        samuel@...lland.org, Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, Greg KH <gregkh@...uxfoundation.org>,
        rafael@...nel.org, daniel.lezcano@...aro.org, tglx@...utronix.de,
        amit.kachhap@...il.com, viresh.kumar@...aro.org,
        lukasz.luba@....com, amitk@...nel.org, rui.zhang@...el.com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        mpe@...erman.id.au, npiggin@...il.com, christophe.leroy@...roup.eu,
        thierry.reding@...il.com, jonathanh@...dia.com,
        tiny.windzz@...il.com, lpieralisi@...nel.org, sudeep.holla@....com,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        anup@...infault.org, chenhuacai@...nel.org,
        jiaxun.yang@...goat.com, Marc Zyngier <maz@...nel.org>,
        vireshk@...nel.org, nm@...com, sboyd@...nel.org,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-riscv@...ts.infradead.org,
        linux-pm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, linux-tegra@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-mips@...r.kernel.org
Subject:     Re: [PATCH 08/19] riscv: Add explicit include for cpu.h

On Wed, 29 Mar 2023 08:52:05 PDT (-0700), robh@...nel.org wrote:
> Removing the include of cpu.h from of_device.h (included by
> of_platform.h) causes an error in setup.c:
>
> arch/riscv/kernel/setup.c:313:22: error: arithmetic on a pointer to an incomplete type 'typeof(struct cpu)' (aka 'struct cpu')
>
> The of_platform.h header is not necessary either, so it can be dropped.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Please ack and I will take the series via the DT tree.
> ---
>  arch/riscv/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 376d2827e736..dcfa4b6fa4b1 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -8,6 +8,7 @@
>   *  Nick Kossifidis <mick@....forth.gr>
>   */
>
> +#include <linux/cpu.h>
>  #include <linux/init.h>
>  #include <linux/mm.h>
>  #include <linux/memblock.h>
> @@ -15,7 +16,6 @@
>  #include <linux/console.h>
>  #include <linux/screen_info.h>
>  #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
>  #include <linux/sched/task.h>
>  #include <linux/smp.h>
>  #include <linux/efi.h>

Reviewed-by: Palmer Dabbelt <palmer@...osinc.com>
Acked-by: Palmer Dabbelt <palmer@...osinc.com>