linux-kernel - Re: [PATCH] tools lib symbol: Use -D_FORTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUOL0FmtMbLQtRx2-_i6uvbsBLsxaAg54x8umT4npT7iA@mail.gmail.com>
Date:   Sat, 29 Apr 2023 14:05:58 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Uwe Kleine-König <ukleinek@...ian.org>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org,
        Diederik de Haas <didi.debian@...ow.org>
Subject: Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

On Mon, Apr 24, 2023 at 3:28 AM Uwe Kleine-König <ukleinek@...ian.org> wrote:
>
> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
> Makefiles with the same problem.
>
> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
> Signed-off-by: Uwe Kleine-König <ukleinek@...ian.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Same problem here I think:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/api/Makefile#n42

Thanks,
Ian

> ---
>  tools/lib/symbol/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/symbol/Makefile b/tools/lib/symbol/Makefile
> index 13d43c6f92b4..4a08cc4e19f2 100644
> --- a/tools/lib/symbol/Makefile
> +++ b/tools/lib/symbol/Makefile
> @@ -39,7 +39,7 @@ endif
>  endif
>
>  ifeq ($(DEBUG),0)
> -  CFLAGS += -D_FORTIFY_SOURCE
> +  CFLAGS += -D_FORTIFY_SOURCE=2
>  endif
>
>  # Treat warnings as errors unless directed not to
> --
> 2.39.2
>