linux-kernel - Re: [PATCH] i3c: ast2600: set variable ast2600_i3c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Apr 2023 10:48:19 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Tom Rix <trix@...hat.com>, alexandre.belloni@...tlin.com
Cc:     linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i3c: ast2600: set variable ast2600_i3c_ops
 storage-class-specifier to static

Hi Tom,

> smatch reports
> drivers/i3c/master/ast2600-i3c-master.c:121:34: warning: symbol
>   'ast2600_i3c_ops' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be
> static.

Super, thanks!

Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>

Cheers,


Jeremy