linux-kernel - Re: [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230430180425.3d24ec12@jic23-huawei>
Date:   Sun, 30 Apr 2023 18:04:25 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: palmas: Remove the unneeded include
 <linux/i2c.h>

On Mon, 24 Apr 2023 09:11:51 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> This driver does not use i2c, so there is no point in including
> <linux/i2c.h>
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Hard to argue with that logic :)

I guess some long ago cut and paste..

Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/adc/palmas_gpadc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index c1c439215aeb..42c519504529 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -14,7 +14,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> -#include <linux/i2c.h>
>  #include <linux/pm.h>
>  #include <linux/mfd/palmas.h>
>  #include <linux/completion.h>