linux-kernel - Re: iwlwifi broken in post-linux-6.3.0 after April 26

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0785e432f1776b3531e8e033cb5b48eeb58b12b6.camel@intel.com>
Date:   Sun, 30 Apr 2023 18:00:44 +0000
From:   "Greenman, Gregory" <gregory.greenman@...el.com>
To:     "jeff.chua.linux@...il.com" <jeff.chua.linux@...il.com>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: Re: iwlwifi broken in post-linux-6.3.0 after April 26

On Sun, 2023-04-30 at 17:06 +0000, Greenman, Gregory wrote:
> On Sun, 2023-04-30 at 18:58 +0800, Jeff Chua wrote:
> > On Sun, Apr 30, 2023 at 2:17 AM Jeff Chua <jeff.chua.linux@...il.com> wrote:
> > > 
> > > On Sat, Apr 29, 2023 at 10:07 PM Bagas Sanjaya <bagasdotme@...il.com> wrote:
> > > > 
> > > > On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> > > > > Can't start wifi on latest linux git pull ... started happening 3 days ago ...
> > > > 
> > > > Are you testing mainline?
> > > 
> > > I'm pulling from https://github.com/torvalds/linux.git, currently at ...
> > > 
> > > commit 1ae78a14516b9372e4c90a89ac21b259339a3a3a (HEAD -> master,
> > > origin/master, origin/HEAD)
> > > Merge: 4e1c80ae5cf4 74d7970febf7
> > > Author: Linus Torvalds <torvalds@...ux-foundation.org>
> > > Date:   Sat Apr 29 11:10:39 2023 -0700
> > > 
> > > > Certainly you should do bisection.
> > > 
> > > ok, will do.
> > 
> > Bisected!
> > 
> > ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65 is the first bad commit
> > commit ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65
> > Author: Gregory Greenman <gregory.greenman@...el.com>
> > Date:   Sun Apr 16 15:47:33 2023 +0300
> > 
> >     wifi: iwlwifi: bump FW API to 77 for AX devices
> > 
> >     Start supporting API version 77 for AX devices.
> > 
> >     Signed-off-by: Gregory Greenman <gregory.greenman@...el.com>
> >     Link: https://lore.kernel.org/r/20230416154301.e522ccefe354.If7628363fafeb7687163103e734206915c445197@changeid
> >     Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> > 
> >  drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > I had to downgrade FW API to 75 to make it work again!
> > 
> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> > 18:27:21.719983505 +0800
> > +++ a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> > 18:27:25.749983446 +0800
> > @@ -10,7 +10,7 @@
> >  #include "fw/api/txq.h"
> > 
> >  /* Highest firmware API version supported */
> > -#define IWL_22000_UCODE_API_MAX        78
> > +#define IWL_22000_UCODE_API_MAX        75
> > 
> >  /* Lowest firmware API version supported */
> >  #define IWL_22000_UCODE_API_MIN        39
> > 
> > 
> > My h/w is Lenovo X1 with ...
> > 
> > 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> > WiFi (rev 01)
> > 
> > 
> > I've the following firmware .. I've tried 77, 78, 79, 81 .. .all not working
> > 
> > -rw-r--r-- 1 root root 1560532 Mar 14 08:05 iwlwifi-so-a0-gf-a0-72.ucode
> > -rw-r--r-- 1 root root 1563692 Mar  6 14:07 iwlwifi-so-a0-gf-a0-73.ucode
> > -rw-r--r-- 1 root root 1577460 Mar 14 08:05 iwlwifi-so-a0-gf-a0-74.ucode
> > -rw-r--r-- 1 root root 1641260 Mar  6 14:07 iwlwifi-so-a0-gf-a0-77.ucode
> > -rw-r--r-- 1 root root 1667236 Mar  6 14:07 iwlwifi-so-a0-gf-a0-78.ucode
> > -rw-r--r-- 1 root root 1672988 Mar  6 14:07 iwlwifi-so-a0-gf-a0-79.ucode
> > -rw-r--r-- 1 root root 1682852 Apr  5 08:22 iwlwifi-so-a0-gf-a0-81.ucode
> > 
> > 
> > # working dmesg attached ...
> > cfg80211: Loading compiled-in X.509 certificates for regulatory database
> > Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> > iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> > iwlwifi 0000:00:14.3: Direct firmware load for
> > iwlwifi-so-a0-gf-a0-75.ucode failed with error -2
> > iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> > thermal thermal_zone1: failed to read out thermal zone (-61)
> > iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> > requested 65536K
> 
> Strangely, I couldn't reproduce it on my system. But, anyway this feature
> better be disabled for a while. I'll send a patch with a fix shortly.
May I ask you to try this fix in [1] (also cc-ed you on the patch itself)?

[1] https://lore.kernel.org/linux-wireless/20230430201830.2f8f88fe49f6.I2f0076ef1d1cbe5d10010549c875b7038ec4c365@changeid/