linux-kernel - Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7a24bac-a81d-6786-f1d3-d0f2c43cee8d@linaro.org>
Date:   Sun, 30 Apr 2023 14:07:58 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Cc:     "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "marex@...x.de" <marex@...x.de>,
        "festevam@...x.de" <festevam@...x.de>,
        "frieder.schrempf@...tron.de" <frieder.schrempf@...tron.de>,
        "marcel.ziswiler@...adex.com" <marcel.ziswiler@...adex.com>,
        "max.krummenacher@...adex.com" <max.krummenacher@...adex.com>,
        "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "matthias.schiffer@...group.com" <matthias.schiffer@...group.com>,
        "denys.drozdov@...adex.com" <denys.drozdov@...adex.com>,
        "leoyang.li@....com" <leoyang.li@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

On 29/04/2023 16:07, Himanshu Bhavani wrote:
> From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM

Please fix your patch format.

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

> 
> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
>                - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
>                - variscite,var-som-mx8mm   # i.MX8MM Variscite VAR-SOM-MX8MM module
>                - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
> +              - fsl,imx8mm-emtop          # i.MX8MM Emtop SOM

Messed order, incorrect vendor prefix. Also board name looks actually
missing.

Best regards,
Krzysztof