| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <9433a896eae368a65f430f4eb7310c56da81d954.1682941568.git.christophe.jaillet@wanadoo.fr>
Date: Mon, 1 May 2023 14:40:29 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: hch@....de, sagi@...mberg.me, kch@...dia.com
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH 5/5] nvmet: Reorder fields in 'struct nvmefc_fcp_req'
Group some variables based on their sizes to reduce holes.
On x86_64, this shrinks the size of 'struct nvmefc_fcp_req' from
112 to 104 bytes.
This structure is embedded in some other structures (nvme_fc_fcp_op
which itself is embedded in nvme_fcp_op_w_sgl), so it helps reducing the
size of these structures too.
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
Using pahole
Before:
======
struct nvmefc_fcp_req {
void * cmdaddr; /* 0 8 */
void * rspaddr; /* 8 8 */
dma_addr_t cmddma; /* 16 8 */
dma_addr_t rspdma; /* 24 8 */
u16 cmdlen; /* 32 2 */
u16 rsplen; /* 34 2 */
u32 payload_length; /* 36 4 */
struct sg_table sg_table; /* 40 16 */
struct scatterlist * first_sgl; /* 56 8 */
/* --- cacheline 1 boundary (64 bytes) --- */
int sg_cnt; /* 64 4 */
enum nvmefc_fcp_datadir io_dir; /* 68 4 */
__le16 sqid; /* 72 2 */
/* XXX 6 bytes hole, try to pack */
void (*done)(struct nvmefc_fcp_req *); /* 80 8 */
void * private; /* 88 8 */
u32 transferred_length; /* 96 4 */
u16 rcv_rsplen; /* 100 2 */
/* XXX 2 bytes hole, try to pack */
u32 status; /* 104 4 */
/* size: 112, cachelines: 2, members: 17 */
/* sum members: 100, holes: 2, sum holes: 8 */
/* padding: 4 */
/* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));
After:
=====
struct nvmefc_fcp_req {
void * cmdaddr; /* 0 8 */
void * rspaddr; /* 8 8 */
dma_addr_t cmddma; /* 16 8 */
dma_addr_t rspdma; /* 24 8 */
u16 cmdlen; /* 32 2 */
u16 rsplen; /* 34 2 */
u32 payload_length; /* 36 4 */
struct sg_table sg_table; /* 40 16 */
struct scatterlist * first_sgl; /* 56 8 */
/* --- cacheline 1 boundary (64 bytes) --- */
int sg_cnt; /* 64 4 */
enum nvmefc_fcp_datadir io_dir; /* 68 4 */
void (*done)(struct nvmefc_fcp_req *); /* 72 8 */
void * private; /* 80 8 */
__le16 sqid; /* 88 2 */
u16 rcv_rsplen; /* 90 2 */
u32 transferred_length; /* 92 4 */
u32 status; /* 96 4 */
/* size: 104, cachelines: 2, members: 17 */
/* padding: 4 */
/* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));
---
include/linux/nvme-fc-driver.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/nvme-fc-driver.h b/include/linux/nvme-fc-driver.h
index fa092b9be2fd..4109f1bd6128 100644
--- a/include/linux/nvme-fc-driver.h
+++ b/include/linux/nvme-fc-driver.h
@@ -185,7 +185,6 @@ enum nvmefc_fcp_datadir {
* @first_sgl: memory for 1st scatter/gather list segment for payload data
* @sg_cnt: number of elements in the scatter/gather list
* @io_dir: direction of the FCP request (see NVMEFC_FCP_xxx)
- * @sqid: The nvme SQID the command is being issued on
* @done: The callback routine the LLDD is to invoke upon completion of
* the FCP operation. req argument is the pointer to the original
* FCP IO operation.
@@ -194,12 +193,13 @@ enum nvmefc_fcp_datadir {
* while processing the operation. The length of the buffer
* corresponds to the fcprqst_priv_sz value specified in the
* nvme_fc_port_template supplied by the LLDD.
+ * @sqid: The nvme SQID the command is being issued on
*
* Values set by the LLDD indicating completion status of the FCP operation.
* Must be set prior to calling the done() callback.
+ * @rcv_rsplen: length, in bytes, of the FCP RSP IU received.
* @transferred_length: amount of payload data, in bytes, that were
* transferred. Should equal payload_length on success.
- * @rcv_rsplen: length, in bytes, of the FCP RSP IU received.
* @status: Completion status of the FCP operation. must be 0 upon success,
* negative errno value upon failure (ex: -EIO). Note: this is
* NOT a reflection of the NVME CQE completion status. Only the
@@ -219,14 +219,14 @@ struct nvmefc_fcp_req {
int sg_cnt;
enum nvmefc_fcp_datadir io_dir;
- __le16 sqid;
-
void (*done)(struct nvmefc_fcp_req *req);
void *private;
- u32 transferred_length;
+ __le16 sqid;
+
u16 rcv_rsplen;
+ u32 transferred_length;
u32 status;
} __aligned(sizeof(u64)); /* alignment for other things alloc'd with */
--
2.34.1
Powered by blists - more mailing lists