linux-kernel - Re: [PATCH v3 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6835178f8f58f6fce7797953f64c3f4c959d6ade.camel@linux.intel.com>
Date:   Mon, 01 May 2023 09:01:04 -0500
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Fenghua Yu <fenghua.yu@...el.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, vkoul@...nel.org
Cc:     dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, giovanni.cabiddu@...el.com,
        hdanton@...a.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v3 01/15] dmaengine: idxd: add wq driver name support
 for accel-config user tool

Hi Fenghua,

On Fri, 2023-04-28 at 17:14 -0700, Fenghua Yu wrote:
> Hi, Tom,
> 
> On 4/28/23 13:55, Tom Zanussi wrote:
> > From: Dave Jiang <dave.jiang@...el.com>
> > 
> > With the possibility of multiple wq drivers that can be bound to
> > the wq,
> > the user config tool accel-config needs a way to know which wq
> > driver to
> > bind to the wq. Introduce per wq driver_name sysfs attribute where
> > the user
> > can indicate the driver to be bound to the wq. This allows accel-
> > config to
> > just bind to the driver using wq->driver_name.
> > 
> > Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > ---
> 
> ...
> 
> > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> > index 7ced8d283d98..505118fc19de 100644
> > --- a/drivers/dma/idxd/idxd.h
> > +++ b/drivers/dma/idxd/idxd.h
> > @@ -214,6 +214,8 @@ struct idxd_wq {
> >         char name[WQ_NAME_SIZE + 1];
> >         u64 max_xfer_bytes;
> >         u32 max_batch_size;
> > +
> > +       char driver_name[WQ_NAME_SIZE + 1];
> 
> It's confused to use "WQ_NAME_SIZE" for driver name size.
> Maybe it's better to have a new definition "DRIVER_NAME_SIZE"?
> BTW, WQ_NAME_SIZE is 1024 which is unnecessary big for storing 
> driver_name[] in the structure. It would be better to have a smaller 
> size (e.g. 128) in DRIVER_NAME_SIZE.

Yes, that makes sense - I'll add an IAA_DRIVER_NAME_SIZE of 128 and use
that instead.

Thanks,

Tom

> 
> Thanks.
> 
> -Fenghua