linux-kernel - Re: [PATCH] accessibility: use C99 array init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230501013219.e4ekzxgoequdlmsu@begin>
Date:   Mon, 1 May 2023 03:32:19 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Mushahid Hussain <mushi.shar@...il.com>,
        William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>, speakup@...ux-speakup.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] accessibility: use C99 array init

Randy Dunlap, le dim. 30 avril 2023 17:16:17 -0700, a ecrit:
> Use C99 array initializer syntax for consistency with other array
> initializers around it and to eliminate a sparse warning:
> 
> drivers/accessibility/speakup/main.c:1290:26: sparse: warning: obsolete array initializer, use C99 syntax
> 
> Fixes: f43241aafedb ("accessibility: speakup: Specify spk_vars among module parameters")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Mushahid Hussain <mushi.shar@...il.com>
> Cc: William Hubbs <w.d.hubbs@...il.com>
> Cc: Chris Brannon <chris@...-brannons.com>
> Cc: Kirk Reiser <kirk@...sers.ca>
> Cc: Samuel Thibault <samuel.thibault@...-lyon.org>
> Cc: speakup@...ux-speakup.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Thanks!

> ---
>  drivers/accessibility/speakup/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
> --- a/drivers/accessibility/speakup/main.c
> +++ b/drivers/accessibility/speakup/main.c
> @@ -1287,7 +1287,7 @@ static struct var_t spk_vars[NB_ID] = {
>  	[PUNC_LEVEL_ID] = { PUNC_LEVEL, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
>  	[READING_PUNC_ID] = { READING_PUNC, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
>  	[CURSOR_TIME_ID] = { CURSOR_TIME, .u.n = {NULL, 120, 50, 600, 0, 0, NULL} },
> -	[SAY_CONTROL_ID] { SAY_CONTROL, TOGGLE_0},
> +	[SAY_CONTROL_ID] = { SAY_CONTROL, TOGGLE_0},
>  	[SAY_WORD_CTL_ID] = {SAY_WORD_CTL, TOGGLE_0},
>  	[NO_INTERRUPT_ID] = { NO_INTERRUPT, TOGGLE_0},
>  	[KEY_ECHO_ID] = { KEY_ECHO, .u.n = {NULL, 1, 0, 2, 0, 0, NULL} },
>