[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230501171409.syub4ro3kb3r6ho2@mobilestation>
Date: Mon, 1 May 2023 20:14:09 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Joy Chakraborty <joychakr@...gle.com>,
Mark Brown <broonie@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Serge Semin <Sergey.Semin@...kalelectronics.ru>,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
manugautam@...gle.com, rohitner@...gle.com
Subject: Re: [PATCH v9 0/5] spi: dw: DW SPI DMA Driver updates
@Mark, @Andy
On Thu, Apr 27, 2023 at 12:33:09PM +0000, Joy Chakraborty wrote:
> This Patch series adds support for 32 bits per word trasfers using DMA
> and some defensive checks around dma controller capabilities.
I've done with reviewing and testing the series. My tags are already
added to the patch logs. @Andy do you still have any comments about
the updated patchset? If none, @Mark please merge it in if you are ok
with the changes.
-Serge(y)
> ---
> V1 Changes : Add support for AxSize=4 bytes to support 32bits/word.
> ---
> V1->V2 Changes : Add dma capability check to make sure address widths
> are supported.
> ---
> V2->V3 Changes : Split changes , add DMA direction check and other
> cosmetic chnages.
> ---
> V3->V4 Changes : Fix Sparce Warning
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303270715.w9sMJhIh-lkp@intel.com/
> ---
> V4->V5 Changes : Preserve reverse xmas Tree order, move direction
> check before initalisation of further capabilities, remove zero
> initialisations, remove error OR'ing.
> ---
> V5->V6 Changes :
> -Remove case of n_bytes=3 using 4_bytes buswidth
> -Avoid forward decaration
> -Break capability check patch into 2
> -round n_bytes to power of 2 ( Bug Fix)
> -Add more explanation in commit text.
> ---
> V6->V7 Changes : Remove extra spaces, refer to functions in commit as
> func()
> ---
> V7->V8 Changes : Minor commment updates in patch 4/5
> ---
> V8->V9 Changes : Minor formatting changes in patch 5/5
> ---
>
> Joy Chakraborty (5):
> spi: dw: Add 32 bpw support to SPI DW DMA driver
> spi: dw: Move dw_spi_can_dma()
> spi: dw: Add DMA directional capability check
> spi: dw: Add DMA address widths capability check
> spi: dw: Round of n_bytes to power of 2
>
> drivers/spi/spi-dw-core.c | 5 ++-
> drivers/spi/spi-dw-dma.c | 76 +++++++++++++++++++++++++++++----------
> drivers/spi/spi-dw.h | 1 +
> 3 files changed, 63 insertions(+), 19 deletions(-)
>
> --
> 2.40.1.495.gc816e09b53d-goog
>
Powered by blists - more mailing lists