[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230501185533.GD1597476@hirez.programming.kicks-ass.net>
Date: Mon, 1 May 2023 20:55:33 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: chris hyser <chris.hyser@...cle.com>
Cc: linux-kernel@...r.kernel.org, dietmar.eggemann@....com,
vincent.guittot@...aro.org, Chen Yu <yu.c.chen@...el.com>,
Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v4] sched/numa: Fix divide by zero for
sysctl_numa_balancing_scan_size.
On Mon, May 01, 2023 at 12:21:17PM -0400, chris hyser wrote:
> In terms of actually wanting to fix this, I'm a bit confused. It clearly was
> worth fixing the first time around (it has your sign-off), and the only
> thing that has changed is that that fix no longer works.
Well, the amount of effort to fix it has dramatically increased, 40+
extra lines vs 2 extra lines.
> > If we do find we want this (why?!) then should we not invest in a better
> > debugfs_create_u32_minmax() or something so that we don't get to add 40+
> > lines for everthing we want to add limits on?
>
> I will look at a way to greatly simplify the bounds checking here as you
> suggest.
Thanks, that might make it all a lot nicer indeed.
Powered by blists - more mailing lists