linux-kernel - Re: [PATCH v3 07/15] dmaengine: idxd: add callback support for iaa crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40de89f7-a87a-283d-9da0-d0681d12a541@intel.com>
Date:   Mon, 1 May 2023 13:48:39 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <vkoul@...nel.org>
CC:     <dave.jiang@...el.com>, <tony.luck@...el.com>,
        <wajdi.k.feghali@...el.com>, <james.guilford@...el.com>,
        <kanchana.p.sridhar@...el.com>, <giovanni.cabiddu@...el.com>,
        <hdanton@...a.com>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH v3 07/15] dmaengine: idxd: add callback support for iaa
 crypto



On 4/28/23 13:55, Tom Zanussi wrote:
> Create a lightweight callback interface to allow idxd sub-drivers to
> be notified when work sent to idxd wqs has completed.
> 
> For a sub-driver to be notified of work completion, it needs to:
> 
>    - Set the descriptor's 'Request Completion Interrupt'
>      (IDXD_OP_FLAG_RCI)
> 
>    - Set the sub-driver desc_complete() callback when registering the
>      sub-driver e.g.:
> 
>        struct idxd_device_driver my_drv = {
>              .probe = my_probe,
>              .desc_complete = my_complete,
>        }
> 
>    - Set the sub-driver-specific context in the sub-driver's descriptor
>      e.g:
> 
>        idxd_desc->crypto.req = req;
>        idxd_desc->crypto.tfm = tfm;
>        idxd_desc->crypto.src_addr = src_addr;
>        idxd_desc->crypto.dst_addr = dst_addr;
> 
> When the work completes and the completion irq fires, idxd will invoke
> the desc_complete() callback with pointers to the descriptor, context,
> and completion_type.
> 
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua