linux-kernel - Re: [PATCH v3 00/46] Fix perf on Intel hybrid CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fX=W-Ck21QuC=Onywtn-dfThBPzvGhbj8oLK8VxLwWoiw@mail.gmail.com>
Date:   Mon, 1 May 2023 13:51:11 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ahmad Yasin <ahmad.yasin@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Perry Taylor <perry.taylor@...el.com>,
        Samantha Alt <samantha.alt@...el.com>,
        Caleb Biggers <caleb.biggers@...el.com>,
        Weilin Wang <weilin.wang@...el.com>,
        Edward Baker <edward.baker@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Florian Fischer <florian.fischer@...q.space>,
        Rob Herring <robh@...nel.org>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        John Garry <john.g.garry@...cle.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Leo Yan <leo.yan@...aro.org>,
        Yang Jihong <yangjihong1@...wei.com>,
        James Clark <james.clark@....com>,
        Suzuki Poulouse <suzuki.poulose@....com>,
        Kang Minchul <tegongkang@...il.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/46] Fix perf on Intel hybrid CPUs

On Mon, May 1, 2023 at 1:35 PM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>
>
>
> On 2023-04-29 1:34 a.m., Ian Rogers wrote:
> > Sample output is contained in the v1 patch set:
> > https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/
> >
> > Tested on Tigerlake, Skylake and Alderlake CPUs.
>
> The metrics and metricgroups tests are failed on a hybrid machine.
> Seems we need the no group trick for more metrics?
>
> ./perf test "perf all metricgroups test"
> 102: perf all metricgroups test                                      :
> FAILED!
>
>
> Testing DataSharing
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument)
> for event (cpu_core/topdown-fe-bound/).
> /bin/dmesg | grep -i perf may provide additional information.
>
> test child finished with -1
> ---- end ----
> perf all metricgroups test: FAILED!
>
>
>
>
> ./perf test "perf all metrics test"
> 103: perf all metrics test                                           :
> FAILED!
>
> Testing tma_info_branctest child finished with -1
> ---- end ----
> perf all metrics test: FAILED!
>
> Testing tma_contested_accesses
> Metric 'tma_contested_accesses' not printed in:
> Error:
> Invalid event (cpu_core/topdown-fe-bound/) in per-thread mode, enable
> system wide with '-a'.
>
> Metric 'tma_dram_bound' not printed in:
> Error:
> Invalid event (cpu_core/topdown-mem-bound/) in per-thread mode, enable
> system wide with '-a'.
>
>
> Metric 'tma_data_sharing' not printed in:
> Error:
> Invalid event (cpu_core/topdown-fe-bound/) in per-thread mode, enable
> system wide with '-a'.
>
>
> Thanks,
> Kan

This is expected. Metrics test fails on Icelake, metricgroups doesn't
validate output but I can expect metricgroups like "transaction" to
have issues. We want to have better tests and this comes under what
we're hoping to achieve with the Valkyrie project.

Thanks,
Ian