linux-kernel - Re: [PATCH v2 4/6] Input: cyttsp5 - properly initialize the device as a pm wakeup device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFBV/ZfxumlQZHGk@google.com>
Date:   Mon, 1 May 2023 17:14:53 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Maximilian Weigand <mweigand@...igand.net>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: [PATCH v2 4/6] Input: cyttsp5 - properly initialize the device
 as a pm wakeup device

Hi Maximilian,

On Mon, May 01, 2023 at 01:30:08PM +0200, Maximilian Weigand wrote:
> When used as a wakeup source the driver should be properly registered
> with the pm system using device_init_wakeup.

This is an I2C device and I2C core already handles setting up a device
as a wakeup source, this patch is not needed as far as I can tell.

> 
> Signed-off-by: Maximilian Weigand <mweigand@...igand.net>
> Reviewed-by: Alistair Francis <alistair@...stair23.me>
> ---
>  drivers/input/touchscreen/cyttsp5.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index 55abf568bdf6..f701125357f0 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -830,6 +830,9 @@ static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq,
>  		return error;
>  	}
>  
> +	if (device_property_read_bool(dev, "wakeup-source"))
> +		device_init_wakeup(dev, true);
> +
>  	error = cyttsp5_startup(ts);
>  	if (error) {
>  		dev_err(ts->dev, "Fail initial startup r=%d\n", error);
> -- 
> 2.39.2
> 

Thanks.

-- 
Dmitry