linux-kernel - Re: [PATCH] tty: define hung_up_tty_compat_ioctl with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67eeec7d-a114-07e0-de56-08a63d91af58@kernel.org>
Date:   Tue, 2 May 2023 07:02:03 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Tom Rix <trix@...hat.com>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: define hung_up_tty_compat_ioctl with CONFIG_COMPAT

On 01. 05. 23, 4:56, Tom Rix wrote:
> gcc reports
> drivers/tty/tty_io.c:446:13: error: ‘hung_up_tty_compat_ioctl’
>    defined but not used [-Werror=unused-function]
>    446 | static long hung_up_tty_compat_ioctl(struct file *file,
>        |             ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> hung_up_tty_compat_ioctl is used conditionally with CONFIG_COMPAT,
> so it should be likewise defined.



> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/tty/tty_io.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 553182753098..7fe404d56ce7 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -443,11 +443,13 @@ static long hung_up_tty_ioctl(struct file *file, unsigned int cmd,
>   	return cmd == TIOCSPGRP ? -ENOTTY : -EIO;
>   }
>   
> +#ifdef CONFIG_COMPAT
>   static long hung_up_tty_compat_ioctl(struct file *file,
>   				     unsigned int cmd, unsigned long arg)
>   {
>   	return cmd == TIOCSPGRP ? -ENOTTY : -EIO;
>   }
> +#endif
>   
>   static int hung_up_tty_fasync(int fd, struct file *file, int on)
>   {

Hi,

Arnd sent a better fix already:
https://lore.kernel.org/all/20230429203523.538756-1-arnd@kernel.org/

thanks,
-- 
js
suse labs