linux-kernel - Re: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2023 08:33:20 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@...log.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "lee@...nel.org" <lee@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI
 MAX77658 Battery

On 01/05/2023 22:20, Arslanbenzer, Zeynep wrote:

>> You already said it above.
>>
>>> +      in battery.yaml, with the following properties being required:
>>> +      - alert-celsius
>>> +
>>> +required:
>>> +  - compatible
>>
>> Why reg and monitored-batter are not required?
>>
> If no monitored-battery information is supplied, we set default values for alert-celsius.

So the device can operate without battery? Interesting... are you sure,
you can physically remove battery and device will work?

> The reg property is the I2C address of the device and it is part of the parent schema. Therefore, both are not required in this file.

What does it mean "in parent schema"? You have reg here, so how parent
schema is related to this?

Since you did not reply, I assume all other comments will be implemented.

Best regards,
Krzysztof