linux-kernel - Re: [PATCH v1 2/5] ASoC: dt-bindings: Add tas2781 amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7085d83-cee1-4f93-c698-74c52bb16222@linaro.org>
Date:   Tue, 2 May 2023 08:51:17 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shenghao Ding <13916275206@....com>, devicetree@...r.kernel.org
Cc:     krzysztof.kozlowski+dt@...aro.org, broonie@...nel.org,
        lgirdwood@...il.com, kevin-lu@...com, shenghao-ding@...com,
        alsa-devel@...a-project.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, x1077012@...com, peeyush@...com,
        navada@...com, gentuser@...il.com
Subject: Re: [PATCH v1 2/5] ASoC: dt-bindings: Add tas2781 amplifier

On 02/05/2023 07:31, Shenghao Ding wrote:
> Create tas2781.yaml for tas2781 driver.
> 
> Signed-off-by: Shenghao Ding <13916275206@....com>
> 
> ---
> Changes in v1:
>  - Submit together with tas2781 codec driver code

I did not get anything else, only this patch.

>  Changes to be committed:
> 	new file:   Documentation/devicetree/bindings/sound/ti,tas2781.yaml

You named it v1, so this changelog or naming seems incorrect. There was
v5 or v6, right? What changed here? There were several comments to your
patches. Since nothing changed, I assume you need to implement them again.

Please implement all the comments Rob asked. Then write a changelog
describing what you changed.



Best regards,
Krzysztof