Message-ID: <5bcb2741-9212-f1aa-335b-6bc4b6fad448@linaro.org>
Date:   Tue, 2 May 2023 09:26:32 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Herve Codina <herve.codina@...tlin.com>,
        Rob Herring <robh@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/4] dt-bindings: sound: Add simple-iio-aux

On 26/04/2023 09:36, Herve Codina wrote:
> Hi Rob,
> 
> On Tue, 25 Apr 2023 12:30:29 -0500
> Rob Herring <robh@...nel.org> wrote:
> 
>> On Fri, Apr 21, 2023 at 02:41:19PM +0200, Herve Codina wrote:
>>> Industrial I/O devices can be present in the audio path.
>>> These devices needs to be viewed as audio components in order to be
>>> fully integrated in the audio path.
>>>
>>> simple-iio-aux allows to consider these Industrial I/O devices as
>>> auxliary audio devices.  
>>
>> What makes it simple? Any binding called simple or generic is a trigger 
>> for me. Best to avoid those terms. :)
> 
> I choose simple-iio-aux because some simple-* already exists.
> For instance simple-audio-amplifier or simple-audio-mux.
> 
> Do you prefer audio-iio-aux ?
> Let me know if I should change.

It means that often what people call "simple" and "generic" works only
for their specific case, because it is not really simple and generic.
After some time the "simple" and "generic" becomes "complicated" and
"huge". Conclusion: sometimes simple and generic bindings are bad idea
and you should have something specific.

Your description in the binding also does not help to match it to
specific, real device. Provide the examples, as Rob asked.

...

>>> +  io-channels:
>>> +    description:
>>> +      Industrial I/O device channels used
>>> +
>>> +  io-channel-names:
>>> +    description:
>>> +      Industrial I/O channel names related to io-channels.
>>> +      These names are used to provides sound controls, widgets and routes names.
>>> +
>>> +  invert:  
>>
>> Property names should globally only have 1 type definition. This is 
>> generic enough I'd be concerned that's not the case.
> 
> What do you mean ?

It is quite likely this will interfere with other properties having the
same name but different type/definition. If you want to keep it named
generic, then please investigate how this would affect any other
bindings. So easier is to make it not that generic, some more specific name.

> 
>>
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +    description: |
>>> +      A list of 0/1 flags defining whether or not the related channel is
>>> +      inverted
>>> +    items:
>>> +      enum: [0, 1]
>>> +      default: 0
>>> +      description: |
>>> +        Invert the sound control value compared to the IIO channel raw value.
>>> +          - 1: The related sound control value is inverted meaning that the
>>> +               minimum sound control value correspond to the maximum IIO channel
>>> +               raw value and the maximum sound control value correspond to the
>>> +               minimum IIO channel raw value.
>>> +          - 0: The related sound control value is not inverted meaning that the
>>> +               minimum (resp maximum) sound control value correspond to the
>>> +               minimum (resp maximum) IIO channel raw value.
>>> +
>>> +required:
>>> +  - compatible
>>> +  - io-channels
>>> +  - io-channel-names
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    aux {
>>> +        compatible = "simple-iio-aux";
>>> +        io-channels = <&iio 0>, <&iio 1>, <&iio 2>, <&iio 3>;
>>> +        io-channel-names = "CH0", "CH1", "CH2", "CH3";  
>>
>> Not really useful names. Do you have a real example?
> 
> As Mark said, for IIO channel, using CHx makes sense.
> See below, I provide a full example.
> 
>>
>>> +        /* Invert CH1 and CH2 */
>>> +        invert = <0 1 1>;  
>>
>> IMO, invert should be same length as io-channels.
> 
> I will update.
> 
> Related to this topic, when I wrote this binding, I wanted to add some
> rules/constraints in order to:
> - Have this property optional
> - If present, force to have as many items in the invert array as the
>   number of items present in the io-channels array.
> 
> I never succeed in writing the constraint for the invert property.
> It should be possible (it is done for some 'foo' 'foo-names' pair such
> as clocks).
> Can you tell me if possible in my case and give me some pointers ?
> 
>>
>>> +    };  
>>
>> How do support multiple instances? Say you have 2 sound cards (or 1 
>> sound card with multiple audio paths) each with different sets of IIO 
>> channels associated with it. You'd need a link to each 'aux' node. Why 
>> not just add io-channels to the sound card nodes directly? That's 
>> already just a virtual, top-level container node grouping all the 
>> components. I don't see why we need another virtual node grouping a 
>> subset of them.
> 
> I don't see what you mean.
> I use a simple-audio-card and here is a full example using several
> instances:

Just like Rob said: "You'd need a link to each 'aux' node"

and you did it...

So now the rest of Rob's answer:

"Why not just add io-channels to the sound card nodes directly? That's
already just a virtual, top-level container node grouping all the
components. I don't see why we need another virtual node grouping a
subset of them."

Why do you need another node if it is not really representing a real,
separate device?

Best regards,
Krzysztof

Powered by blists - more mailing lists