linux-kernel - RE: [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2023 08:05:37 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc'

Hi Krzysztof,

> On 02/05/2023 07:04, Stanley Chang wrote:
> > Add a new compatible name 'snps,dwc3-rtk-soc' of DT for realtek dwc3
> > core to adjust the global register start address
> >
> > The RTK DHC SoCs were designed, the global register address offset at
> 
> What are: "RTK" and "DHC"? These are manufactured by Synopsys as you
> suggest in the patch?

RTK is Realtek.
DHC is the department name in Realtek and the abbreviation of the Digital Home Center.
The USB controller of RTK DHC SoCs used the DWC3 IP of Synopsys.

> > 0x8100. The default address offset is constant at
> > DWC3_GLOBALS_REGS_START (0xc100). Therefore, add the compatible
> name
> > of device-tree to specify the SoC custom's global register start address.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>
> 
> Based on your email, rtk could mean Realtek, so the compatible is clearly
> wrong.

The compatible name "snps,dwc3-rtk-soc" wants to represent the dwc3 driver, which requires a different offset for Realtek SoCs

> > ---
> >  v3 to v4 change:
> > Use the compatible name to specify the global register address offset.
> > If the compatible name is "snps,dwc3-rtk-soc", then the offset use 0x8100.
> > Otherwise, the offset is default value 0xc100.
> >
> 
> Best regards,
> Krzysztof
> 
> 
> ------Please consider the environment before printing this e-mail.