linux-kernel - Re: [PATCH 0/8] Add RK3588 OTP memory support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2023 08:26:19 +0000
From:   Vincent Legoll <vincent.legoll@...il.com>
To:     Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Shreeya Patel <shreeya.patel@...labora.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Finley Xiao <finley.xiao@...k-chips.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH 0/8] Add RK3588 OTP memory support

Hello,

On Mon, May 1, 2023 at 8:44 AM Cristian Ciocaltea
<cristian.ciocaltea@...labora.com> wrote:
> This patch series adds OTP memory support for Rockchip RK3588 SoC,
> while also providing a few improvements to the existing rockchip-otp
> driver, in addition to converting the bindings to dt-schema.

I tested this on a QuartzPro64 dev board, I applied your series top of my tree:
Collabora's rk3588-v6.3 + some DT patches to add support for the qp64 board.

Here is the output from the commands you told me to try:

# ls -1 /sys/bus/nvmem/devices/*/nvmem
/sys/bus/nvmem/devices/rockchip-otp0/nvmem

#  od -N 64 -A x -t x1z -v /sys/bus/nvmem/devices/rockchip-otp0/nvmem
000000 52 4b 35 88 91 fe 21 41 5a 43 39 36 00 00 00 00  >RK5...!AZC96....<
000010 00 00 00 00 0f 0b 0d 0a 0a 0c 25 0e 00 00 00 00  >..........%.....<
000020 00 00 00 00 00 00 00 00 08 0c 00 00 00 00 00 00  >................<
000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  >................<
000040

This is working as expected.

You can add my T-B, for the whole series:

Tested-by: Vincent Legoll <vincent.legoll@...il.com>

Regards

--
Vincent Legoll