linux-kernel - Re: [PATCH] reset: starfive: select AUXILIARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBLGcym0GnRnDPsFU-d8vL_hr+mFaN2PJtFB2RY22KEJqpY0w@mail.gmail.com>
Date:   Tue, 2 May 2023 13:40:59 +0200
From:   Emil Renner Berthing <kernel@...il.dk>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, Hal Feng <hal.feng@...rfivetech.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] reset: starfive: select AUXILIARY_BUS

On Tue, 2 May 2023 at 12:20, Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@...il.dk>
> Cc: Hal Feng <hal.feng@...rfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

Makes sense to me. Thanks!
Reviewed-by: <emil.renner.berthing@...onical.com>

> ---
>  drivers/reset/starfive/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>
>  config RESET_STARFIVE_JH7110
>         bool "StarFive JH7110 Reset Driver"
> -       depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> +       depends on CLK_STARFIVE_JH7110_SYS
> +       select AUXILIARY_BUS
>         select RESET_STARFIVE_JH71X0
>         default ARCH_STARFIVE
>         help
> --
> 2.39.2
>