linux-kernel - Re: [EXT] Re: [net PATCH v4 09/10] octeontx2-af: Skip PFs if not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZFD6GIS+lrVn4AJs@corigine.com>
Date:   Tue, 2 May 2023 13:55:04 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Ratheesh Kannoth <rkannoth@...vell.com>
Cc:     Sai Krishna Gajula <saikrishnag@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [EXT] Re: [net PATCH v4 09/10] octeontx2-af: Skip PFs if not
 enabled

On Tue, May 02, 2023 at 03:10:53AM +0000, Ratheesh Kannoth wrote:
> Hi Simon,
> 
> Thanks for your review. Please find replies inline. 
> 
> -Ratheesh
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@...igine.com>
> > Sent: Wednesday, April 26, 2023 3:31 PM
> > To: Sai Krishna Gajula <saikrishnag@...vell.com>
> > Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> > pabeni@...hat.com; netdev@...r.kernel.org; linux-
> > kernel@...r.kernel.org; leon@...nel.org; Sunil Kovvuri Goutham
> > <sgoutham@...vell.com>; Geethasowjanya Akula <gakula@...vell.com>;
> > Linu Cherian <lcherian@...vell.com>; Jerin Jacob Kollanukkaran
> > <jerinj@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
> > Subbaraya Sundeep Bhatta <sbhatta@...vell.com>; Ratheesh Kannoth
> > <rkannoth@...vell.com>
> > Subject: [EXT] Re: [net PATCH v4 09/10] octeontx2-af: Skip PFs if not enabled
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On Wed, Apr 26, 2023 at 01:13:44PM +0530, Sai Krishna wrote:
> > > From: Ratheesh Kannoth <rkannoth@...vell.com>
> > >
> > > Fiwmware enables set of PFs and allocate mbox resources based on the
> > > number of enabled PFs. Current driver tries to initialize the mbox
> > > resources even for disabled PFs, which may waste the resources.
> > > This patch fixes the issue by skipping the mbox initialization of
> > > disabled PFs.
> > 
> > FWIIW, this feels more like an enhancement than a fix to me.
>
> [Ratheesh Kannoth] I agree, commit message convey this change as
> enhancement. But this Code change fixes a crash in driver.  We will
> modify the commit message as below in next Patchset version.  " Firmware
> enables PFs and allocate mbox resources for each of the PFs.  Currently
> PF driver configures mbox resources without checking whether PF is
> enabled or not. This results in crash. This patch fixes this issue by
> skipping disabled PF's mbox initialization. "

Thanks, much appreciated.