linux-kernel - Re: [PATCH] reset: mpfs: select AUXILIARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230502-uneven-configure-0f7e322e7a5c@wendy>
Date:   Tue, 2 May 2023 13:07:01 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>
CC:     <linux-kernel@...r.kernel.org>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] reset: mpfs: select AUXILIARY_BUS

On Tue, May 02, 2023 at 12:20:41PM +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
> 
> Cc: Conor Dooley <conor.dooley@...rochip.com>
> Cc: Daire McNamara <daire.mcnamara@...rochip.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/reset/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 6aa8f243b30c..086cb23debba 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -154,7 +154,8 @@ config RESET_PISTACHIO
>  
>  config RESET_POLARFIRE_SOC
>  	bool "Microchip PolarFire SoC (MPFS) Reset Driver"
> -	depends on AUXILIARY_BUS && MCHP_CLK_MPFS
> +	depends on MCHP_CLK_MPFS

I think this `depends on` makes this patch moot, as MCHP_CLK_MPFS
selects AUXILIARY_BUS. I don't really mind if it's switched to select
for consistency, or removed entirely though, so:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> +	select AUXILIARY_BUS
>  	default MCHP_CLK_MPFS
>  	help
>  	  This driver supports peripheral reset for the Microchip PolarFire SoC
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)