linux-kernel - Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CSBUZL6M3MSS.316JRNGXVMLB@wheely>
Date:   Wed, 03 May 2023 00:24:24 +1000
From:   "Nicholas Piggin" <npiggin@...il.com>
To:     "Palmer Dabbelt" <palmer@...belt.com>
Cc:     "Arnd Bergmann" <arnd@...db.de>, <linux-arch@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <vgupta@...nel.org>,
        <linux-snps-arc@...ts.infradead.org>, <bcain@...cinc.com>,
        <linux-hexagon@...r.kernel.org>, <chenhuacai@...nel.org>,
        <loongarch@...ts.linux.dev>, <geert@...ux-m68k.org>,
        <linux-m68k@...ts.linux-m68k.org>, <monstr@...str.eu>,
        <tsbogend@...ha.franken.de>, <linux-mips@...r.kernel.org>,
        <dinguyen@...nel.org>, <jonas@...thpole.se>,
        <stefan.kristiansson@...nalahti.fi>, <shorne@...il.com>,
        <linux-openrisc@...r.kernel.org>,
        <James.Bottomley@...senPartnership.com>, <deller@....de>,
        <linux-parisc@...r.kernel.org>,
        "Paul Walmsley" <paul.walmsley@...ive.com>,
        <aou@...s.berkeley.edu>, <linux-riscv@...ts.infradead.org>,
        <ysato@...rs.sourceforge.jp>, <dalias@...c.org>,
        <glaubitz@...sik.fu-berlin.de>, <linux-sh@...r.kernel.org>,
        <davem@...emloft.net>, <sparclinux@...r.kernel.org>,
        <richard@....at>, <anton.ivanov@...bridgegreys.com>,
        <johannes@...solutions.net>, <linux-um@...ts.infradead.org>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <khilman@...libre.com>, <frederic@...nel.org>
Subject: Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING_GEN option

On Sun Apr 30, 2023 at 6:14 AM AEST, Palmer Dabbelt wrote:
> On Fri, 28 Apr 2023 23:33:48 PDT (-0700), npiggin@...il.com wrote:
> > This option was created in commit 554b0004d0ec4 ("vtime: Add
> > HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig") for architectures to indicate
> > they support the 64-bit cputime_t required for VIRT_CPU_ACCOUNTING_GEN.
> >
> > The cputime_t type has since been removed, so this doesn't have any
> > meaning. Remove it.
> >
> > Cc: linux-arch@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Cc: Vineet Gupta <vgupta@...nel.org>
> > Cc: linux-snps-arc@...ts.infradead.org
> > Cc: Brian Cain <bcain@...cinc.com>
> > Cc: linux-hexagon@...r.kernel.org
> > Cc: Huacai Chen <chenhuacai@...nel.org>
> > Cc: loongarch@...ts.linux.dev
> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Cc: linux-m68k@...ts.linux-m68k.org
> > Cc: Michal Simek <monstr@...str.eu>
> > Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > Cc: linux-mips@...r.kernel.org
> > Cc: Dinh Nguyen <dinguyen@...nel.org>
> > Cc: Jonas Bonn <jonas@...thpole.se>
> > Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
> > Cc: Stafford Horne <shorne@...il.com>
> > Cc: linux-openrisc@...r.kernel.org
> > Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
> > Cc: Helge Deller <deller@....de>
> > Cc: linux-parisc@...r.kernel.org
> > Cc: Paul Walmsley <paul.walmsley@...ive.com>
> > Cc: Palmer Dabbelt <palmer@...belt.com>
> > Cc: Albert Ou <aou@...s.berkeley.edu>
> > Cc: linux-riscv@...ts.infradead.org
> > Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> > Cc: Rich Felker <dalias@...c.org>
> > Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> > Cc: linux-sh@...r.kernel.org
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: sparclinux@...r.kernel.org
> > Cc: Richard Weinberger <richard@....at>
> > Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
> > Cc: Johannes Berg <johannes@...solutions.net>
> > Cc: linux-um@...ts.infradead.org
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> > Cc: x86@...nel.org
> > Cc: "H. Peter Anvin" <hpa@...or.com>
> > Cc: Kevin Hilman <khilman@...libre.com>
> > Cc: Frederic Weisbecker <frederic@...nel.org>
> > Signed-off-by: Nicholas Piggin <npiggin@...il.com>
> > ---
> > Hi,
> >
> > Could we tidy this? I don't know what tree it can go in, timers,
> > sched, asm-generic, probably doesn't matter.
> >
> > The only thing this actually does is gate VIRT_CPU_ACCOUNTING_GEN and
> > NO_HZ_FULL so if your arch has some other issue that requires this
> > then the documentation needs to change. Any concerns from the archs?
> > I.e., 32-bit that does *not* define HAVE_VIRT_CPU_ACCOUNTING_GEN
> > which looks to be:
> >
> > arc
> > hexagon
> > loongarch 32-bit with SMP
> > m68k
> > microblaze
> > mips 32-bit with SMP
> > nios2
> > openrisc
> > parisc 32-bit
> > riscv 32-bit
>
> Nothing's jumping out, though I haven't tested this yet so I'm not 100%.  
> I assume this isn't aimed for this merge window, given the timing?  

No, maybe the next one though.

> Probably best to give this sort of thing time to bake in linux-next, but 
> I doubt anyone is even paying attention to rv32/NO_HZ_FULL so no big 
> deal either way on my end.
>
> Acked-by: Palmer Dabbelt <palmer@...osinc.com> # RISC-V

Thanks,
Nick