linux-kernel - RE: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR03MB5197EB4B34DC82C62EF5A3798B6F9@MN2PR03MB5197.namprd03.prod.outlook.com>
Date:   Tue, 2 May 2023 15:05:18 +0000
From:   "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@...log.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "lee@...nel.org" <lee@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: RE: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI
 MAX77658 Battery

On Tue, 2 May 2023, Krzysztof Kozlowski wrote:
>On 01/05/2023 22:20, Arslanbenzer, Zeynep wrote:
>
>>> You already said it above.
>>>
>>>> +      in battery.yaml, with the following properties being required:
>>>> +      - alert-celsius
>>>> +
>>>> +required:
>>>> +  - compatible
>>>
>>> Why reg and monitored-batter are not required?
>>>
>> If no monitored-battery information is supplied, we set default values for alert-celsius.
>
>So the device can operate without battery? Interesting... are you sure, you can physically remove battery and device will work?
>

I mean if battery info is not supplied, we use default values.

ret = power_supply_get_battery_info(fg->battery, &info);
if (ret) {
    dev_err(fg->dev, "Unable to get battery info\n");
    fg->temp_alert_min = info->temp_alert_min;
    fg->temp_alert_max = info->temp_alert_max;
} else {
    fg->temp_alert_min = -128;
    fg->temp_alert_max = 127;
}


>> The reg property is the I2C address of the device and it is part of the parent schema. Therefore, both are not required in this file.
>
>What does it mean "in parent schema"? You have reg here, so how parent schema is related to this?

It is my mistake, I will remove reg from here.

Best regards,
Zeynep