linux-kernel - Re: [PATCH] lockd: define nlm_port_min,max with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1b5a29c393e2f6b23420bfc94beceff1be69ae7.camel@kernel.org>
Date:   Tue, 02 May 2023 14:16:50 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Tom Rix <trix@...hat.com>, chuck.lever@...cle.com,
        trond.myklebust@...merspace.com, anna@...nel.org
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockd: define nlm_port_min,max with CONFIG_SYSCTL

On Tue, 2023-05-02 at 14:07 -0400, Tom Rix wrote:
> gcc with W=1 and ! CONFIG_SYSCTL
> fs/lockd/svc.c:80:51: error: ‘nlm_port_max’ defined but not used [-Werror=unused-const-variable=]
>    80 | static const int                nlm_port_min = 0, nlm_port_max = 65535;
>       |                                                   ^~~~~~~~~~~~
> fs/lockd/svc.c:80:33: error: ‘nlm_port_min’ defined but not used [-Werror=unused-const-variable=]
>    80 | static const int                nlm_port_min = 0, nlm_port_max = 65535;
>       |                                 ^~~~~~~~~~~~
> 
> The only use of these variables is when CONFIG_SYSCTL
> is defined, so their definition should be likewise conditional.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  fs/lockd/svc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index bb94949bc223..04ba95b83d16 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -77,9 +77,9 @@ static const unsigned long	nlm_grace_period_min = 0;
>  static const unsigned long	nlm_grace_period_max = 240;
>  static const unsigned long	nlm_timeout_min = 3;
>  static const unsigned long	nlm_timeout_max = 20;
> -static const int		nlm_port_min = 0, nlm_port_max = 65535;
>  
>  #ifdef CONFIG_SYSCTL
> +static const int		nlm_port_min = 0, nlm_port_max = 65535;
>  static struct ctl_table_header * nlm_sysctl_table;
>  #endif
>  

Reviewed-by: Jeff Layton <jlayton@...nel.org>