linux-kernel - Re: [PATCH v3 3/3] perf test: Add selftest to test IBS invocation via core pmu events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90a2a0dd-62e1-93a2-6d8a-50c68823078b@amd.com>
Date:   Tue, 2 May 2023 08:38:10 +0530
From:   Ravi Bangoria <ravi.bangoria@....com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     peterz@...radead.org, namhyung@...nel.org, eranian@...gle.com,
        acme@...nel.org, mark.rutland@....com, jolsa@...nel.org,
        bp@...en8.de, kan.liang@...ux.intel.com, adrian.hunter@...el.com,
        maddy@...ux.ibm.com, x86@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        sandipan.das@....com, ananth.narayan@....com,
        santosh.shukla@....com, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v3 3/3] perf test: Add selftest to test IBS invocation via
 core pmu events

On 30-Apr-23 2:39 AM, Ian Rogers wrote:
> On Tue, Apr 25, 2023 at 7:23 AM Ravi Bangoria <ravi.bangoria@....com> wrote:
>>
>> IBS pmu can be invoked via fixed set of core pmu events with 'precise_ip'
>> set to 1. Add a simple event open test for all these events.
>>
>> Without kernel fix:
>>   $ sudo ./perf test -vv 76
>>    76: AMD IBS via core pmu                                      :
>>   --- start ---
>>   test child forked, pid 6553
>>   Using CPUID AuthenticAMD-25-1-1
>>   type: 0x0, config: 0x0, fd: 3  -  Pass
>>   type: 0x0, config: 0x1, fd: -1  -  Pass
>>   type: 0x4, config: 0x76, fd: -1  -  Fail
>>   type: 0x4, config: 0xc1, fd: -1  -  Fail
>>   type: 0x4, config: 0x12, fd: -1  -  Pass
>>   test child finished with -1
>>   ---- end ----
>>   AMD IBS via core pmu: FAILED!
>>
>> With kernel fix:
>>   $ sudo ./perf test -vv 76
>>    76: AMD IBS via core pmu                                      :
>>   --- start ---
>>   test child forked, pid 7526
>>   Using CPUID AuthenticAMD-25-1-1
>>   type: 0x0, config: 0x0, fd: 3  -  Pass
>>   type: 0x0, config: 0x1, fd: -1  -  Pass
>>   type: 0x4, config: 0x76, fd: 3  -  Pass
>>   type: 0x4, config: 0xc1, fd: 3  -  Pass
>>   type: 0x4, config: 0x12, fd: -1  -  Pass
>>   test child finished with 0
>>   ---- end ----
>>   AMD IBS via core pmu: Ok
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@....com>
> 
> Thanks Ravi, as the test is AMD specific I think it makes sense to place it in:
> tools/perf/arch/x86/tests
> and then to update the test list in:
> tools/perf/arch/x86/tests/arch-tests.c

Sure, will respin.

Thanks,
Ravi