linux-kernel - Re: [PATCH v3 6/6] fbdev: Rename fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <828664d0-3562-56cc-019d-1bb8a55826b5@suse.de>
Date:   Wed, 3 May 2023 10:15:46 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     deller@....de, geert@...ux-m68k.org, javierm@...hat.com,
        daniel@...ll.ch, vgupta@...nel.org, chenhuacai@...nel.org,
        kernel@...0n.name, davem@...emloft.net,
        James.Bottomley@...senpartnership.com, arnd@...db.de,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-arch@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
        sparclinux@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-parisc@...r.kernel.org
Subject: Re: [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

Hi

Am 02.05.23 um 22:08 schrieb Sam Ravnborg:
> Hi Thomas.
> 
> On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote:
>> Update the names of the fb_mem*() helpers to be consistent with their
>> regular counterparts. Hence, fb_memset() now becomes fb_memset_io(),
>> fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb()
>> becomes fb_memcpy_toio(). No functional changes.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
>> ---
> ...
>>   
>> -#ifndef fb_memcpy_fromfb
>> -static inline void fb_memcpy_fromfb(void *to, const volatile void __iomem *from, size_t n)
>> +#ifndef fb_memcpy_fromio
>> +static inline void fb_memcpy_fromio(void *to, const volatile void __iomem *from, size_t n)
>>   {
>>   	memcpy_fromio(to, from, n);
>>   }
>> -#define fb_memcpy_fromfb fb_memcpy_fromfb
>> +#define fb_memcpy_fromio fb_memcpy_fromio
>>   #endif
>>   
>> -#ifndef fb_memcpy_tofb
>> -static inline void fb_memcpy_tofb(volatile void __iomem *to, const void *from, size_t n)
>> +#ifndef fb_memcpy_toio
>> +static inline void fb_memcpy_toio(volatile void __iomem *to, const void *from, size_t n)
>>   {
>>   	memcpy_toio(to, from, n);
>>   }
>> -#define fb_memcpy_tofb fb_memcpy_tofb
>> +#define fb_memcpy_toio fb_memcpy_toio
>>   #endif
>>   
>>   #ifndef fb_memset
>> -static inline void fb_memset(volatile void __iomem *addr, int c, size_t n)
>> +static inline void fb_memset_io(volatile void __iomem *addr, int c, size_t n)
>>   {
>>   	memset_io(addr, c, n);
>>   }
>> -#define fb_memset fb_memset
>> +#define fb_memset fb_memset_io
> 
> The static inlines wrappers does not provide any value, and could be replaced by
> direct calls to memcpy_fromio(), memcpy_toio(), memset_io().
> 
> If you decide to keep the wrappers I will not hold you back, so the
> patch has my:
> Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> 
> But I prefer the direct calls without the wrappers....

At first I was also skeptical if those fb_mem*() wrappers are needed. 
But Arnd mentioned that there are subtle differences between the current 
code and Linux' mem*_io() functions. Keeping the wrappers might be needed.

Best regards
Thomas

> 
> 	Sam

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)