linux-kernel - Re: [PATCH v3 4/6] fbdev: Include <linux/io.h> via <asm/fb.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0ecbc92c-7e42-4958-988b-abc265f039bf@app.fastmail.com>
Date:   Wed, 03 May 2023 10:52:34 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thomas Zimmermann" <tzimmermann@...e.de>,
        "Javier Martinez Canillas" <javierm@...hat.com>,
        "Sam Ravnborg" <sam@...nborg.org>
Cc:     Linux-Arch <linux-arch@...r.kernel.org>,
        linux-fbdev@...r.kernel.org, linux-ia64@...r.kernel.org,
        linux-parisc@...r.kernel.org, "Helge Deller" <deller@....de>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
        linux-m68k@...ts.linux-m68k.org,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        loongarch@...ts.linux.dev, "Vineet Gupta" <vgupta@...nel.org>,
        sparclinux@...r.kernel.org, "WANG Xuerui" <kernel@...0n.name>,
        linux-snps-arc@...ts.infradead.org,
        "David S . Miller" <davem@...emloft.net>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 4/6] fbdev: Include <linux/io.h> via <asm/fb.h>

On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote:
> Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann <tzimmermann@...e.de> writes:
>>>>
>>>> There are countless examples where the above are not followed,
>>>> but to my best understanding the above it the preferred way to do it.
>>>
>>> Where did youher this? I only know about this in the case of asm/io.h
>>> vs. linux/io.h.
>>>
>> 
>> I understand that's the case too. I believe even checkpatch.pl complains
>> about it? (not that the script always get right, but just as an example).
>
> Do you know if that's the general rule? If so, we might want to 
> repurpose <asm/fbio.h> for the framebuffer I/O functions.

It's certainly the general trend across all of the kernel to have
drivers prefer including linux/*.h, and to move stuff from asm/*.h
to linux/*.h as it gets generalized across architectures.

     Arnd